cherry-pick the changes from the fork branch #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cobolbaby
changed the title
awaragi
pushed a commit
that referenced
this pull request
Mar 21, 2022
incorporate changes to index.js based on code in #28
awaragi
pushed a commit
that referenced
this pull request
Mar 21, 2022
|
Hi @cobolbaby. Since I had quite few changes, it was easier to copy and paste pieces of code instead of trying to do conflict resolution etc. Version 1.1.x will contain all of these changes. |
awaragi
added a commit
that referenced
this pull request
Mar 24, 2022
* Updated tedious to latest version incorporate changes to index.js based on code in #28 * incorporate changes to metrics.js based on code in #28 * added mssql product version * moved source files to src/ * Moved metric documentation into its own file (updated README) Updated README with list of metrics * updated test and removed duplicate code (by mistake) * update documentation (FAQ) added package-lock.json for deterministic builds added .npmrc so that builds work regardless of environment switch npm install to npm ci (faster and ensures that package-lock.json is present updated version of express (3 high risks indicated by npm audit) * Made e2e test less dependent on mssql version * improved metrics logs * Removed unecessary file Co-authored-by: Pierre Awaragi <pierre.awaragi@cgi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upmetric #27ConnectionError: Connection lost - read ECONNRESET#26